Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-1188] add telemetry event types #1353

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 22, 2022

Motivation

Update types generated from rum-events-format with telemetry events

Changes

Generate types from telemetry event schema

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan force-pushed the bcaudan/telemetry-schema branch from ca3fcad to edb815e Compare February 23, 2022 13:10
@bcaudan bcaudan changed the title add telemetry schema ✨ add telemetry event types Feb 23, 2022
@bcaudan bcaudan force-pushed the bcaudan/telemetry-schema branch 3 times, most recently from eaa15c8 to e57a036 Compare February 23, 2022 13:44
@bcaudan bcaudan force-pushed the bcaudan/telemetry-schema branch from e57a036 to bfcb23a Compare February 24, 2022 13:49
@bcaudan bcaudan changed the title ✨ add telemetry event types ✨[RUMF-1188] add telemetry event types Feb 24, 2022
@bcaudan bcaudan marked this pull request as ready for review February 24, 2022 13:50
@bcaudan bcaudan requested a review from a team as a code owner February 24, 2022 13:50
@bcaudan bcaudan force-pushed the bcaudan/telemetry-schema branch from 9218e8e to 6f0d352 Compare February 24, 2022 14:13
@codecov-commenter
Copy link

Codecov Report

Merging #1353 (6f0d352) into main (59100a2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1353   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files         104      104           
  Lines        4268     4268           
  Branches      950      950           
=======================================
  Hits         3887     3887           
  Misses        381      381           
Impacted Files Coverage Δ
packages/rum-core/test/formatValidation.ts 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59100a2...6f0d352. Read the comment docs.

@bcaudan bcaudan force-pushed the bcaudan/telemetry-schema branch from 886919d to 6f0d352 Compare February 24, 2022 14:30
scripts/generate-schema-types.js Outdated Show resolved Hide resolved
@bcaudan bcaudan merged commit 4175305 into main Feb 24, 2022
@bcaudan bcaudan deleted the bcaudan/telemetry-schema branch February 24, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants